Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Grafana: remove deletion of existing Prometheus datasource #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaysh
Copy link

@jaysh jaysh commented Aug 5, 2019

After setting up alerts within Grafana, I found that if the Prometheus instance was temporarily unavailable, this would cause the alert to fail permanently with:

description = Error: Could not find datasource Data source not found

This would re-trigger until I went into Grafana, and manually re-tested the rule and saved the alert (with no actual changes to the alert, or data sources).

This issue suggests the cause is specifying deleteDatasources which has the same name as datasource defined after it. I tried this in my deployment, then killed prometheus: I witnessed the alerts re-enter pending and then clear automatically with no other side-effects (e.g. duplication of the data source within Grafana).

I'm not aware of why this entry exists, so I have created this quick PR to remove it. If it's needed, please let me know and I'll look at other workarounds.

@jaysh jaysh changed the title Remove deletion of existing Prometheus datasource Grafana: Remove deletion of existing Prometheus datasource Aug 5, 2019
@jaysh jaysh changed the title Grafana: Remove deletion of existing Prometheus datasource Grafana: remove deletion of existing Prometheus datasource Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant